Closed
Conversation
Contributor
Author
|
Please review @itay @David-Noble-at-work |
| from ordereddict import OrderedDict | ||
| from collections import OrderedDict # must be python 2.7 | ||
| except ImportError: | ||
| from ordereddict import OrderedDict # for python 2.6, pip install ordereddict |
Contributor
There was a problem hiding this comment.
The comment is wrong - we don't need pip install, since we package it.
Contributor
|
Looks good - fix the comments and squash and merge. |
…ce links. Also in 'splunklib/searchcommands/search_command.py' on line 1037 - the link is broken. It needs to be fixed.
Fixes issue #141 on GitHub
shakeelmohamed
force-pushed
the
bugfix/python-2.6-compat
branch
from
8e27152 to
b9d60d7
Compare
This was referenced May 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses all obvious errors when using Python 2.6, the issues are primarily in
searchcommands.TODOs:
Closes #141