Skip to content

SYN-4842: excluded file types client - #40

Merged
borisvalo merged 2 commits into
v2from
syn-4842-excluded-file-types-client
Jun 23, 2026
Merged

SYN-4842: excluded file types client#40
borisvalo merged 2 commits into
v2from
syn-4842-excluded-file-types-client

Conversation

@borisvalo

@borisvalo borisvalo commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Resolves SYN-4842


Before the change?

  • syntheticsclient/v2 had browser check model support for excludedFiles, but no client method to discover the API-owned excluded file types.
  • makePublicAPICall printed full dumped requests to stdout after setting X-SF-TOKEN, which could expose API tokens in logs.

After the change?

  • Added ExcludedFileTypesResponse.
  • Added GetExcludedFileTypesV2() for GET /excluded_file_types, parsing the public excludedFileTypes response field.
  • Added unit coverage for the excluded file types client method and parser.
  • Removed stdout request dumping from makePublicAPICall.
  • Preserved RequestDetails.RequestBody compatibility while redacting the client API key before storing request details.

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features) - N/A: client SDK unit-only change.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

N/A. This client SDK change is covered by unit tests.

ok  	github.com/splunk/syntheticsclient/v2/syntheticsclientv2	1.359s

Does this introduce a breaking change?

  • Yes
  • No

@borisvalo borisvalo self-assigned this Jun 21, 2026
@borisvalo borisvalo changed the title Syn 4842 excluded file types client SYN-4842: excluded file types client Jun 22, 2026
@borisvalo
borisvalo merged commit ffb978b into v2 Jun 23, 2026
2 of 6 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
@jcsco
jcsco deleted the syn-4842-excluded-file-types-client branch July 31, 2026 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants