Skip to content

SYN-6665: MFA ToTP client - #43

Merged
borisvalo merged 1 commit into
v2from
syn-6665-totp-client
Jun 23, 2026
Merged

SYN-6665: MFA ToTP client#43
borisvalo merged 1 commit into
v2from
syn-6665-totp-client

Conversation

@borisvalo

@borisvalo borisvalo commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Resolves SYN-6665


Before the change?

  • syntheticsclientv2 did not expose the Synthetics /totps API, so Terraform/provider work could not manage TOTP variables through the released client.
  • RequestDetails.RequestBody could retain sensitive request data, including auth headers and secret request body fields.
  • RequestDetails.RawRequest retained the original request, which could expose API tokens or request-body secrets.

After the change?

  • Adds syntheticsclientv2 TOTP variable models and CRUD methods for /totps.
  • Supports create, get, list, update, and delete using the confirmed API roots: totp and totps.
  • Redacts sensitive request details, including auth/cookie headers, JSON secret, password, and content fields, browser header values, and browser cookie values.
  • Stops retaining RawRequest in RequestDetails to avoid exposing original auth headers or secret request bodies.
  • Adds unit coverage for the TOTP API contract, update pointer semantics, redaction behavior, and non-over-redaction of benign values.

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

Client-only change; no live acceptance tests were run. Unit tests:

go test ./syntheticsclientv2 -tags=unit_tests -run 'TestSanitizeRequestDumpStoredInRequestDetails|Test(Create|Update)TotpVariableV2|TestMakePublicAPICallStoresRedactedRequestDetailsForTotpVariableCRUD' -count=1
ok

go test ./syntheticsclientv2 -tags=unit_tests -count=1
ok

Does this introduce a breaking change?

  • Yes
  • No

@borisvalo borisvalo self-assigned this Jun 22, 2026
@borisvalo borisvalo changed the title Syn 6665 totp client SYN-6665: MFA ToTP client Jun 22, 2026
@borisvalo
borisvalo force-pushed the syn-6665-totp-client branch from 2f88273 to 8ebeab8 Compare June 23, 2026 09:24
@borisvalo
borisvalo force-pushed the syn-6665-totp-client branch from 8ebeab8 to 667405f Compare June 23, 2026 09:39
@borisvalo
borisvalo merged commit 420462d into v2 Jun 23, 2026
2 of 4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
@jcsco
jcsco deleted the syn-6665-totp-client branch July 31, 2026 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants