SYN-6665: MFA ToTP client - #43
Merged
Merged
Conversation
borisvalo
requested review from
bchhay-splunk,
dsanders-splunk,
etipton-splunk and
mtichy-splunk
June 22, 2026 13:00
bchhay-splunk
approved these changes
Jun 22, 2026
borisvalo
force-pushed
the
syn-6665-totp-client
branch
from
June 23, 2026 09:24
2f88273 to
8ebeab8
Compare
borisvalo
force-pushed
the
syn-6665-totp-client
branch
from
June 23, 2026 09:39
8ebeab8 to
667405f
Compare
mtichy-splunk
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SYN-6665
Before the change?
syntheticsclientv2did not expose the Synthetics/totpsAPI, so Terraform/provider work could not manage TOTP variables through the released client.RequestDetails.RequestBodycould retain sensitive request data, including auth headers and secret request body fields.RequestDetails.RawRequestretained the original request, which could expose API tokens or request-body secrets.After the change?
syntheticsclientv2TOTP variable models and CRUD methods for/totps.totpandtotps.secret,password, andcontentfields, browser header values, and browser cookie values.RawRequestinRequestDetailsto avoid exposing original auth headers or secret request bodies.Pull request checklist
make testacc), and pasted in this PR (for bug fixes / features)Acceptance Test Output
Client-only change; no live acceptance tests were run. Unit tests:
Does this introduce a breaking change?