Skip to content

Add collection conditions#1387

Merged
leonard84 merged 4 commits intospockframework:masterfrom
leonard84:1372_new_collection_matchers
Nov 4, 2021
Merged

Add collection conditions#1387
leonard84 merged 4 commits intospockframework:masterfrom
leonard84:1372_new_collection_matchers

Conversation

@leonard84
Copy link
Copy Markdown
Member

resolves #1372

@leonard84 leonard84 self-assigned this Oct 21, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2021

Codecov Report

Merging #1387 (6c8e370) into master (7768079) will increase coverage by 79.28%.
The diff coverage is 75.53%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1387       +/-   ##
=============================================
+ Coverage          0   79.28%   +79.28%     
- Complexity        0     3980     +3980     
=============================================
  Files             0      403      +403     
  Lines             0    12391    +12391     
  Branches          0     1638     +1638     
=============================================
+ Hits              0     9824     +9824     
- Misses            0     1971     +1971     
- Partials          0      596      +596     
Impacted Files Coverage Δ
.../src/main/java/org/spockframework/util/Assert.java 54.54% <ø> (ø)
...g/spockframework/runtime/model/ExpressionInfo.java 72.58% <60.00%> (ø)
.../java/org/spockframework/runtime/SpockRuntime.java 69.78% <68.00%> (ø)
...org/spockframework/compiler/ConditionRewriter.java 91.48% <84.84%> (ø)
...java/org/spockframework/compiler/AstNodeCache.java 100.00% <100.00%> (ø)
...k/runtime/FailedSetEqualityComparisonRenderer.java 96.42% <100.00%> (ø)
...rg/spockframework/runtime/MasterRunSupervisor.java 80.64% <0.00%> (ø)
...untime/extension/builtin/AutoCleanupExtension.java 100.00% <0.00%> (ø)
...a/spock/util/concurrent/BlockingVariablesImpl.java 100.00% <0.00%> (ø)
...g/spockframework/compiler/model/FeatureMethod.java 100.00% <0.00%> (ø)
... and 399 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7768079...6c8e370. Read the comment docs.

@leonard84 leonard84 force-pushed the 1372_new_collection_matchers branch from ab2da9b to 2931c48 Compare October 21, 2021 22:50
@leonard84 leonard84 force-pushed the 1372_new_collection_matchers branch from 2931c48 to ba0d625 Compare October 24, 2021 16:17
@leonard84 leonard84 requested a review from a team October 25, 2021 18:10
marcphilipp
marcphilipp previously approved these changes Nov 1, 2021
Copy link
Copy Markdown
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to using that! 👍

Comment thread docs/utilities.adoc Outdated
Comment thread docs/utilities.adoc Outdated
Comment thread docs/utilities.adoc Outdated
Comment thread spock-core/src/main/java/org/spockframework/runtime/model/ExpressionInfo.java Outdated
Co-authored-by: Marc Philipp <marc@gradle.com>
Co-authored-by: Marc Philipp <marc@gradle.com>
@leonard84 leonard84 enabled auto-merge (squash) November 4, 2021 23:49
@leonard84 leonard84 added this to the 2.1 milestone Nov 4, 2021
@leonard84 leonard84 merged commit 4424e1c into spockframework:master Nov 4, 2021
@leonard84 leonard84 deleted the 1372_new_collection_matchers branch November 4, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new matcher syntax for comparing collections regardless of order

2 participants