Fix context pollution in IterationNode.around()#1446
Merged
leonard84 merged 1 commit intospockframework:masterfrom Mar 14, 2022
Merged
Fix context pollution in IterationNode.around()#1446leonard84 merged 1 commit intospockframework:masterfrom
leonard84 merged 1 commit intospockframework:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1446 +/- ##
============================================
+ Coverage 79.52% 79.53% +0.01%
- Complexity 4006 4007 +1
============================================
Files 404 404
Lines 12547 12550 +3
Branches 1641 1641
============================================
+ Hits 9978 9982 +4
+ Misses 1974 1973 -1
Partials 595 595
Continue to review full report at Codecov.
|
Prior to this commit, any exception thrown in IterationNode.around(), i.e. in an iteration interceptor, would pollute the feature context, affecting the outcome of subsequent iterations and the feature itself. fixes spockframework#1441
3ef018d to
4dd436c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, any exception thrown in IterationNode.around(), i.e. in an iteration interceptor,
would pollute the feature context, affecting the outcome of subsequent iterations and the feature itself.
fixes #1441