-
Notifications
You must be signed in to change notification settings - Fork 480
Add Groovy 6 Alpha 1 as a testing variant #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leonard84
wants to merge
4
commits into
spockframework:master
Choose a base branch
from
leonard84:feat/groovy-6-alpha-testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d046002
Add Groovy 6 Alpha 1 as a testing variant
leonard84 48e4202
Default to minimum required Java version for Groovy 6
leonard84 734ffa0
Bump compiler JDK from 11 to 17
leonard84 d84dea7
Reference the current closure directly instead of via this.find()
leonard84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,4 @@ codecov: | |
|
|
||
| comment: | ||
| layout: "reach, diff, flags, files" | ||
| after_n_builds: 24 | ||
| after_n_builds: 29 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/bin/sh | ||
| for var in 2.5 3.0 4.0 5.0; do | ||
| for var in 2.5 3.0 4.0 5.0 6.0; do | ||
| ./gradlew -Dvariant="$var" "$@" | ||
| done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| @echo off | ||
| for %%v in (2.5 3.0 4.0 5.0) do ( | ||
| for %%v in (2.5 3.0 4.0 5.0 6.0) do ( | ||
| gradlew.bat -Dvariant=%%v %* | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
spock-core/src/main/java/org/spockframework/compiler/CurrentClosureExpression.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| * Copyright 2026 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.spockframework.compiler; | ||
|
|
||
| import org.codehaus.groovy.ast.ClassHelper; | ||
| import org.codehaus.groovy.classgen.BytecodeExpression; | ||
|
|
||
| import groovyjarjarasm.asm.MethodVisitor; | ||
| import groovyjarjarasm.asm.Opcodes; | ||
|
|
||
| /** | ||
| * A direct, delegate-independent reference to the closure that is currently being executed. | ||
| * | ||
| * <p>For implicit-{@code this} <em>method</em> conditions inside {@code with} / {@code verifyAll} / | ||
| * {@code verifyEach} closures, {@link org.spockframework.runtime.SpockRuntime#verifyMethodCondition} | ||
| * must be handed the closure itself as the {@code target}, so that method resolution routes through | ||
| * the closure's delegate (with fallback to the owner/spec). | ||
| * | ||
| * <p>Groovy has no source-level keyword for "the closure I am currently in": inside a closure body a | ||
| * value-context {@code this} compiles to {@code getThisObject()} (the enclosing spec), not the closure. | ||
| * Earlier Spock versions worked around this by emitting {@code this.find()} (and before that | ||
| * {@code this.each(Closure.IDENTITY)}), relying on a no-arg DGM resolving against the closure object. | ||
| * Groovy 6 (GROOVY-11858) resolves in-closure implicit-{@code this} calls against the delegate first, | ||
| * which broke that trick. | ||
| * | ||
| * <p>A closure's {@code doCall} method is always an instance method of the generated {@code Closure} | ||
| * subclass, so local variable 0 is the closure instance. Emitting {@code ALOAD 0} therefore yields the | ||
| * current closure directly, without depending on the meta-object protocol at all. | ||
| */ | ||
| class CurrentClosureExpression extends BytecodeExpression { | ||
|
|
||
| CurrentClosureExpression() { | ||
| super(ClassHelper.CLOSURE_TYPE); | ||
| } | ||
|
|
||
| @Override | ||
| public void visit(MethodVisitor mv) { | ||
| // load "this" of the enclosing doCall method, i.e. the closure instance itself | ||
| mv.visitVarInsn(Opcodes.ALOAD, 0); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the java versions from the different os types intentional?
Why Linux 8 and 11 and Windows + Mac 17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groovy 6 requires Java 17, so those Linux builds get excluded. And win+mac are
include, i.e., adding executions.