Add ReusableBlockingVariable to allow reset the state of the variable…#721
Closed
guenhter wants to merge 1 commit intospockframework:masterfrom
guenhter:master
Closed
Add ReusableBlockingVariable to allow reset the state of the variable…#721guenhter wants to merge 1 commit intospockframework:masterfrom guenhter:master
guenhter wants to merge 1 commit intospockframework:masterfrom
guenhter:master
Conversation
… instead of creating a new one in the spec
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
============================================
+ Coverage 73.16% 73.18% +0.02%
- Complexity 3088 3094 +6
============================================
Files 341 342 +1
Lines 9639 9653 +14
Branches 1201 1201
============================================
+ Hits 7052 7065 +13
- Misses 2144 2145 +1
Partials 443 443
Continue to review full report at Codecov.
|
Member
|
FYI, we won't merge any new features until 1.1 is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often it's needed to use the same BlockingVariable again but reset it. E.g. when the variable is used for Messaging and is contained in a consumer. Than it isn't always that easy to replace the existing variable with a new instance. So I added a simple reset method which resets the value and the CountDownLatch of the BlockingVariable.
This also was suggested in
#312
So it is now possible to do:
(I know, this samples can be split up to own tests, but there are other circumstances where such cases are needed)
This change is