feat(cli): align flag names across commands with deprecated aliases (#309-314) - #333
Merged
Conversation
…309-314) One canonical flag name per concept, everywhere; old spellings kept as deprecated (hidden) aliases so nothing breaks. Part of the 2026-07-11 audit (#328, Phase 2). - --subnet → --subnet-id (launch) [#311] - --key-pair → --key-name (launch) [#313] - --security-group{,s,-id} → --security-group-ids (launch/autoscale/burst/ image import); launch now accepts MULTIPLE security groups [#312] - --tags → --tag (autoscale launch), repeatable key=value like launch [#310] - path --output/-o → --output-file / --output-dir (queue results, queue template generate/init, slurm convert, pipeline collect); these shadowed the root -o/--output format flag [#309] - pipeline launch --detached deprecated: launch is always async, flag was a no-op (use --wait) [#314] flag_conventions_test.go gains a check that fails if any historical spelling is reintroduced without MarkDeprecated. All aliases verified accepted; canonical names shown in --help; go build/vet/test green.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Jul 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309, #310, #311, #312, #313, #314. Part of the audit tracker #328 (Phase 2 — flag standardization batch). Every rename ships a deprecated (hidden) alias, so no existing invocation breaks.
Canonical names (one per concept, everywhere)
--subnet-id--subnet--key-name--key-pair--security-group-ids--security-group,--security-groups,--security-group-id--tag(repeatablekey=value)--tags(StringToString)--output-file/--output-dir--output/-oFunctional fixes bundled in
spawn launchnow accepts multiple security groups (was limited to one) — the flag is now aStringSlicefeeding the config's existingSecurityGroupIDs []string.--output/-oflags shadowed the root-o/--outputformat flag (same bug class as the just-fixedvalidate -o json). Renamed to--output-file/--output-dir; a smalloutputFileFlag()helper reads canonical-then-deprecated for the two anonymous template flags.pipeline launch --detachedwas a dead no-op (declared, registered, never read; pipeline launch invokes the orchestrator Lambda and always returns). Deprecated with a message pointing at--wait, rather than renaming a flag that does nothing.Regression lock
flag_conventions_test.gogains a check that fails if any historical spelling (subnet,key-pair,security-group{,s,-id},tags) is reintroduced withoutMarkDeprecated— so this drift can't creep back (directly on the "reduce confusion" goal).Scope note
Deliberately not in this PR (deferred to doc-only per the Phase 2 scoping decision): the cosmetic verb renames (#304 describe→show, #307 policy/activity, #308 cost flatten, #316 --on-idle, #317 --wait). Grouping regroupings (#305, #306) are their own follow-up PRs.
Verification
go build ./...,go vet ./cmd,gofmtclean.TestFlagConventions(extended) passes; affected cmd tests green.--helpon launch/autoscale/burst/image import; deprecated aliases still accepted (no "unknown flag"). Pre-existing unrelatedTestCatalogValid(feat(plugin): permissions declaration block (#388) #392) still fails onmain.CHANGELOG under Deprecated.