feat: convert onboarding skill to MCP-only#45
Merged
Conversation
Replace all Confidence REST API calls with MCP tool calls across the onboarding skill and all 4 warehouse setup skills. Only create-account remains on REST (no account exists yet to authenticate MCP). Changes: - invite-user: REST curl → mcp__confidence-flags__inviteUser - create-client: REST curl → createClient + getClientSecret MCP tools - setup-wizard: remove REST fallbacks, require MCP auth at Step 2 - setup-warehouse (all 4 types): replace curl calls to metrics/connectors APIs with validateWarehouseConfig, createWarehouse, createFlagAppliedConnection, createEventConnection, createAssignmentTable, and createCryptoKey MCP tools - Remove ~1400 lines of token management, Auth0 scripts, REST templates, and gRPC transcoding rules that are no longer needed Cloud-provider operations (gcloud, aws, snowsql, bq) and telemetry remain as Bash commands — only Confidence API calls moved to MCP. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
After /mcp auth, the agent waited for explicit user confirmation due to local-command-caveat wrapping. Now proceeds on any next user message. Targeting rule defaulted to user_id which doesn't exist on new accounts. Now checks context schema first to use the correct entity field. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicklasl
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the onboarding skill from REST API calls to MCP tool calls for all Confidence operations. Only
create-accountremains on REST (no account exists yet to authenticate MCP).What changed
Main skill (
onboard-confidence/SKILL.md):invite-user: REST curl →inviteUserMCP toolcreate-client: REST curl →createClient+getClientSecretMCP toolssetup-wizard: removed REST fallback, MCP auth required at Step 2 (not optional)Warehouse skills (all 4 types):
curltometrics.*/v1/dataWarehouseConfig:validate→validateWarehouseConfigcurltometrics.*/v1/dataWarehouses→createWarehousecurltoconnectors.*/v1/flagAppliedConnections→createFlagAppliedConnectioncurltoconnectors.*/v1/eventConnections→createEventConnectioncurltometrics.*/v1/assignmentTables→createAssignmentTablecurltoiam.*/v1/cryptoKeys→createCryptoKeyDepends on
konfidens-mcp PR #348 (deployed) which added all the MCP tools these skills now use.
Test plan
/onboard-confidence setup-wizardend-to-end with MCP/onboard-confidence invite-userwith MCP/onboard-confidence setup-warehousefor at least one warehouse typecreate-accountstill works via REST (no MCP needed)🤖 Generated with Claude Code