Fix rotate CLI skipping endpoints due to list mutation during iteration#71
Merged
Merged
Conversation
`old_cert.endpoints` is a live SQLAlchemy relationship. When `request_rotation` reassigns `endpoint.certificate = new_cert`, the endpoint is removed from the collection mid-iteration, causing one endpoint to be skipped per rotation call. Wrap in `list()` to snapshot the collection before iterating.
Coverage Report for CI Build 28855530653Coverage remained the same at 59.879%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
old_cert.endpointsis a live SQLAlchemy relationship. Whenrequest_rotationreassignsendpoint.certificate = new_cert, the endpoint is removed from the collection mid-iteration, causing one endpoint to be skipped per rotation call.Wrap in
list()to snapshot the collection before iterating.