Workaround BigTableIO to write Iterable of KV (#1057) #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevillelyh
force-pushed
the
andrisnoko/bigtable
branch
from
6192241 to
0be7b86
Compare
ravwojdyla
reviewed
Apr 13, 2018
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| class BigtableBulkWriter |
Contributor
There was a problem hiding this comment.
Please add populateDisplayData where applicable.
ravwojdyla
reviewed
Apr 13, 2018
| final Iterable<KV<ByteString, Iterable<Mutation>>> elements = c.element(); | ||
| final Iterator<KV<ByteString, Iterable<Mutation>>> iterator = elements.iterator(); | ||
|
|
||
| while (iterator.hasNext()) { |
Contributor
There was a problem hiding this comment.
if you do foreach here you will save one line of code.
ravwojdyla
reviewed
Apr 13, 2018
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| class BigtableBulkWriter |
Contributor
There was a problem hiding this comment.
There are testing missing for this transform.
ravwojdyla
reviewed
Apr 13, 2018
|
|
||
| private final int numOfShards; | ||
|
|
||
| AssignToShard(int numOfShards) { |
ravwojdyla
reviewed
Apr 13, 2018
| */ | ||
| class BigtableWriteException extends IOException { | ||
|
|
||
| public BigtableWriteException(KV<ByteString, Iterable<Mutation>> record, Throwable cause) { |
Contributor
There was a problem hiding this comment.
final to the parameters
ravwojdyla
reviewed
Apr 13, 2018
| @@ -0,0 +1,30 @@ | |||
| /* | |||
| * Copyright 2017 Spotify AB. | |||
ravwojdyla
reviewed
Apr 13, 2018
| @@ -0,0 +1,212 @@ | |||
| /* | |||
| * Copyright 2017 Spotify AB. | |||
Contributor
nevillelyh
force-pushed
the
andrisnoko/bigtable
branch
from
445e5f8 to
834c0c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
==========================================
+ Coverage 81.82% 82.45% +0.62%
==========================================
Files 119 119
Lines 4011 3983 -28
Branches 460 437 -23
==========================================
+ Hits 3282 3284 +2
+ Misses 729 699 -30
Continue to review full report at Codecov.
|
Contributor
regadas
reviewed
Apr 17, 2018
| * Hepler to test createBulkShards. | ||
| */ | ||
| private static class TestPTransform extends | ||
| PTransform<PCollection<KV<ByteString, Iterable<Mutation>>>, |
Contributor
There was a problem hiding this comment.
🎨 the formatting looks weird
regadas
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #1057