Skip to content

Conversation

@inejc
Copy link
Contributor

@inejc inejc commented Apr 25, 2018

Fixes #1061.

Copy link
Contributor

@andrewsmartin andrewsmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

Codecov Report

Merging #1127 into master will decrease coverage by 9.75%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1127      +/-   ##
=========================================
- Coverage   81.66%   71.9%   -9.76%     
=========================================
  Files         119     119              
  Lines        4019    3983      -36     
  Branches      403     354      -49     
=========================================
- Hits         3282    2864     -418     
- Misses        737    1119     +382
Impacted Files Coverage Δ
...in/scala/com/spotify/scio/values/SCollection.scala 75.09% <0%> (-3.25%) ⬇️
...scala/com/spotify/scio/bigquery/MockBigQuery.scala 0% <0%> (-95.13%) ⬇️
...la/com/spotify/scio/bigquery/dynamic/package.scala 0% <0%> (-94.45%) ⬇️
...cio/bigquery/dynamic/DynamicDestinationsUtil.scala 0% <0%> (-80%) ⬇️
...n/scala/com/spotify/scio/bigtable/TableAdmin.scala 0% <0%> (-80%) ⬇️
...ala/com/spotify/scio/bigquery/BigQueryClient.scala 14.11% <0%> (-67.57%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 45% <0%> (-55%) ⬇️
...ala/com/spotify/scio/avro/types/TypeProvider.scala 45.31% <0%> (-42.19%) ⬇️
...n/scala/com/spotify/scio/avro/types/AvroType.scala 55.55% <0%> (-33.34%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 68.75% <0%> (-25%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d15e6...b0d46b8. Read the comment docs.

@ravwojdyla ravwojdyla merged commit 115caad into spotify:master Apr 26, 2018
@inejc inejc deleted the bug/typed-bq-sink-name branch May 2, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants