fix #1025, cache schema in Avro SchemaProvider#1359
Merged
nevillelyh merged 1 commit intomasterfrom Sep 12, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1359 +/- ##
==========================================
- Coverage 83.26% 83.22% -0.05%
==========================================
Files 125 125
Lines 4028 4029 +1
Branches 438 463 +25
==========================================
- Hits 3354 3353 -1
- Misses 674 676 +2
Continue to review full report at Codecov.
|
regadas
approved these changes
Sep 11, 2018
Contributor
There was a problem hiding this comment.
@nevillelyh LGTM, however for this simple case i think you can get slightly better performance with a ConcurrentHashMap.
regadas
reviewed
Sep 11, 2018
|
|
||
| private[types] object SchemaProvider { | ||
|
|
||
| private val m: scala.collection.concurrent.Map[Type, Schema] = |
jto
approved these changes
Sep 12, 2018
nevillelyh
force-pushed
the
neville/avro
branch
from
573a8cc to
849c605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.