GenericRecord fallback warning #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jto
force-pushed
the
julient/avro-fallback-warning
branch
from
a2b620a to
230411c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1768 +/- ##
==========================================
+ Coverage 71.65% 71.67% +0.01%
==========================================
Files 176 176
Lines 5398 5401 +3
Branches 409 421 +12
==========================================
+ Hits 3868 3871 +3
Misses 1530 1530
Continue to review full report at Codecov.
|
regadas
reviewed
Mar 21, 2019
scio-macros/src/main/scala/com/spotify/scio/coders/CoderMacros.scala
Outdated
Show resolved
Hide resolved
Contributor
|
@jto I think this needs some rebase. |
clairemcginty
approved these changes
Mar 21, 2019
Contributor
clairemcginty
left a comment
clairemcginty
left a comment
There was a problem hiding this comment.
looks good! do we want to add a deprecation warning for 0.8?
jto
force-pushed
the
julient/avro-fallback-warning
branch
from
230411c to
e0a5428
Compare
nevillelyh
pushed a commit
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compile time warning when Coder fallsback to Kryo on GenericRecord