check jobReference.location for query location #2845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevillelyh
commented
Apr 3, 2020
|
|
||
| it should "support missing source tables" in { | ||
| bq.query.extractLocation("SELECT 6") shouldBe None | ||
| bq.query.extractLocation("SELECT 6") shouldBe Some("EU") |
Contributor
Author
There was a problem hiding this comment.
So this means the query will be executed in EU despite not having any source table.
I'm not sure how it defaults to EU though, a project-wide setting?
Contributor
There was a problem hiding this comment.
this seems like it's probably reading your local config?
regadas
reviewed
Apr 3, 2020
scio-bigquery/src/main/scala/com/spotify/scio/bigquery/client/QueryOps.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
- Coverage 71.84% 71.78% -0.06%
==========================================
Files 221 221
Lines 7362 7366 +4
Branches 320 321 +1
==========================================
- Hits 5289 5288 -1
- Misses 2073 2078 +5
Continue to review full report at Codecov.
|
regadas
approved these changes
Apr 3, 2020
regadas
added a commit
to regadas/scio
that referenced
this pull request
Apr 7, 2020
This reverts commit efecafe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the tables referenced are backed by Cloud SQL, etc.,
referencedTablesis empty butjobReference.locationis still available for query location.