Skip to content

Conversation

@regadas
Copy link
Contributor

@regadas regadas commented Aug 3, 2020

Fixes #3218

@regadas regadas changed the title Fix: ByteBuffer should be readOnly Fix: BigQuery fromAvro ByteBuffer should be readOnly Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #3220 into master will decrease coverage by 2.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3220      +/-   ##
==========================================
- Coverage   72.95%   70.34%   -2.61%     
==========================================
  Files         232      232              
  Lines        7639     7639              
  Branches      322      325       +3     
==========================================
- Hits         5573     5374     -199     
- Misses       2066     2265     +199     
Impacted Files Coverage Δ
...potify/scio/bigquery/types/ConverterProvider.scala 100.00% <ø> (ø)
...scala/com/spotify/scio/bigquery/client/Cache.scala 0.00% <0.00%> (-74.08%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0.00% <0.00%> (-70.59%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0.00% <0.00%> (-52.50%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50.00% <0.00%> (-50.00%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 19.35% <0.00%> (-41.94%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.73% <0.00%> (-39.71%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0.00% <0.00%> (-36.85%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0.00%> (-29.17%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (-25.00%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dda41d...f4cb461. Read the comment docs.

@nevillelyh nevillelyh merged commit ac6714f into spotify:master Aug 3, 2020
@regadas regadas deleted the 3218_bq_avro_mutation branch August 3, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQueryType fromAvro causes IllegalMutationException

2 participants