Skip to content

Un-deprecate macro annotations to avoid magnolify serialization issues, deprecate typed avro and BQ methods#5846

Merged
kellen merged 4 commits intomainfrom
kellen/undep
Dec 16, 2025
Merged

Un-deprecate macro annotations to avoid magnolify serialization issues, deprecate typed avro and BQ methods#5846
kellen merged 4 commits intomainfrom
kellen/undep

Conversation

@kellen
Copy link
Copy Markdown
Contributor

@kellen kellen commented Dec 16, 2025

The scala @deprecated annotation is not serializable. Classes that are annotated with a deprecated macro function inherit that deprecation annotation. If such a class is used with magnolify (e.g. AvroType or ParquetType), that deprecation annotation is incorporated into a magnolia CaseClass representation and contained within the derived type, which itself must be serializable. It will not be serializable due to the annotation and usage in beam will fail.

We sidestep this issue by annotating the scio classes which use the macro annotations instead of deprecating the macro annotations themselves. 🫠

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.49%. Comparing base (b793dbd) to head (d909673).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5846   +/-   ##
=======================================
  Coverage   61.48%   61.49%           
=======================================
  Files         317      317           
  Lines       11650    11650           
  Branches      845      845           
=======================================
+ Hits         7163     7164    +1     
+ Misses       4487     4486    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kellen kellen merged commit 7ab1e05 into main Dec 16, 2025
21 of 23 checks passed
@kellen kellen deleted the kellen/undep branch December 16, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants