Make Voyager index and names filenames configurable#5914
Merged
clairemcginty merged 6 commits intospotify:mainfrom Apr 1, 2026
Merged
Make Voyager index and names filenames configurable#5914clairemcginty merged 6 commits intospotify:mainfrom
clairemcginty merged 6 commits intospotify:mainfrom
Conversation
Add optional indexFile and namesFile parameters to VoyagerUri and asVoyagerSideInput, defaulting to the existing "index.hnsw" and "names.json" values. This allows users to specify custom filenames when the index files at a given path don't use the default names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies end-to-end write and read via sc.voyagerSideInput using custom index and names filenames on VoyagerUri. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies that the voyagerSideInput(uri) overload (which reads index settings from v2 metadata) works correctly with custom filenames. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5914 +/- ##
==========================================
+ Coverage 61.54% 61.70% +0.15%
==========================================
Files 317 317
Lines 11653 11654 +1
Branches 822 815 -7
==========================================
+ Hits 7172 7191 +19
+ Misses 4481 4463 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add binary compatibility filters for the 46 incompatibilities caused by VoyagerUri changing from AnyVal to a regular case class. Verified against 0.15.3. Also adds a test for the no-settings voyagerSideInput overload with custom filenames. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
clairemcginty
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the voyager integration assumes that the index file and names file will always be constant
index.hnswandnames.json, respectively. This is not always the case (e.g. sharded indices) so we want to support user-provided filenames. This PR adds just that, allowing the user to specify the filenames for the index and names file at the already provided storage URI.