Fix bytecode ordering dependency in GatewayAutoConfigurationTests#3985
Merged
ryanjbaxter merged 1 commit intoNov 19, 2025
Merged
Conversation
…uffling The test was failing intermittently under NonDex shuffling due to Spring Boot's inability to read metadata for TestEnableWebfluxSecurityAutoConfiguration - a test-only autoconfiguration class. When NonDex reorders bytecode, Spring Boot's ClassPathResource loading fails because the class is not properly accessible during metadata resolution. This fix uses FilteredClassLoader to exclude TestEnableWebfluxSecurityAutoConfiguration from the test context, preventing the flakiness while maintaining test integrity. The test was classified as Implementation-Dependent (ID) by NonDex, indicating that its behavior depends on bytecode ordering rather than logical test flow. Signed-off-by: kcruz28 <kcruz28@illinois.edu>
Kcruz28
force-pushed
the
fix/nondex-nettyHttpClientConfigured-flakiness
branch
from
November 18, 2025 11:14
9de347b to
626b6f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Found this while running NonDex on the test suite. When running the test suite with certain bytecode reordering patterns,
GatewayAutoConfigurationTests.nettyHttpClientConfiguredfails because Spring Bootcannot resolve metadata for
TestEnableWebfluxSecurityAutoConfiguration.The issue occurs because:
AutoConfigurationSortertries to read metadata forTestEnableWebfluxSecurityAutoConfigurationFileNotFoundExceptionthat breaks the testSolution
Use Spring Boot's
FilteredClassLoaderto explicitly excludeTestEnableWebfluxSecurityAutoConfigurationfrom the test's classloader. This prevents Spring Boot from trying to discover and load metadata for
the test-only autoconfiguration, while keeping all other functionality intact.
The change is minimal:
.withClassLoader(new FilteredClassLoader(...))to exclude the problematic classWhy This Matters
This type of issue indicates a hidden dependency on bytecode ordering within the test setup.
By fixing it, we: