Property default-binder doesnt seem to work

[mwesox]

There is a property spring.cloud.stream.default-binder, where you can define the default binder, in case you have multiple binders on your classpath.

It seems like the kinesis binder is ignoring the property and there is no way in switching the binder.
We try to use a rabbit binder for local development and even by setting the property spring.cloud.stream.default-binder=rabbit always the kinesis binder was used.

We use the following dependency together with Spring Cloud version (Greenwich.SR1)

<dependency>
      <groupId>org.springframework.cloud</groupId>
      <artifactId>spring-cloud-stream-binder-kinesis</artifactId>
      <version>1.2.0.RELEASE</version>
</dependency>

[artembilan]

Does it mean that Kafka or Rabbit binders work well in this case?
Sounds suspicious: just because this is not a particular binder responsibility to worry about that option...

Would be great to have some simple project to let us to reproduce.

Thanks for understanding

[mwesox]

Based on the documentation Kafka and Rabbit should work, event though I haven't tested it.

We try to use rabbit for local development and kinesis for stages. I'll try to create a sample project.

[artembilan]

Well, there is no difference in between binder implementation. So, I'm not sure why you treat Kinesis as specific one and assume that Kafka or Rabbit are going to work.
I just mean that this could be some general problem of Spring Cloud Stream per se and not specific to Kinesis binder.
Therefore would be great to have something to play with and don't be so strict for this particular binder and really try to confirm that all others work or behave the same way and then move this issue into Spring Cloud Stream project.

Thanks for understanding

[mwesox]

Ok while comparing it with the documentation, I saw that I had a typo.

Wrong: spring.cloud.stream.default-binder Correct: spring.cloud.stream.defaultBinder

[mwesox]

sorry, but I have to reopen the issue, as I had again the same error. I've debugged it now and identified the issue in the org.springframework.cloud.stream.binder.DefaultBinderFactory and method getBinder.

If a binder on the context is found, then the spring.cloud.stream.defaultBinder is ignored, as it takes only the one, which is on the context.
This is problematic, cause in our case, there was a kinesis binder on the context, but no rabbit , as the rabbit relies on the "old" bootstrap.

else if (binders.size() == 1) {
			binder = binders.values().iterator().next();

Hence the spring.cloud.stream.default-binder setting has been ignored.

[artembilan]

Moved to Spring Cloud Stream project since it looks like nothing to do with Kinesis Binder per se.

Thanks

[olegz]

Actually I am not sure I fully understand what you're trying to say. The code in question is this:

String binderName = StringUtils.hasText(name) ? name : this.defaultBinder;
. . .
if (StringUtils.hasText(binderName) && binders.containsKey(binderName)) {
	binder = (Binder<T, ConsumerProperties, ProducerProperties>) this.context
					.getBean(binderName);
}
else if (binders.size() == 1) {
	binder = binders.values().iterator().next();
}
. . .

. . . which effectively says see if a binder identified as a defaultBinder is found and if not and we only have one binder give it to us.
Sure we can perhaps revisit it and throw an exception if a specific binder is not found, but what I am actually trying to say is that in your configuration it only sees a single binder.

[olegz]

Closing it due to the lack of follow up from the reporter. Please feel free to re-open it if more details and instructions on how to reproduce it are provided