Move GemFire configuration to inner class#1168
Closed
jhuynh1 wants to merge 1 commit into
Closed
Conversation
…atch other vector store projects
sobychacko
requested changes
Aug 17, 2024
| return new Builder(); | ||
| } | ||
|
|
||
| public static class Builder { |
Contributor
There was a problem hiding this comment.
In many of our other vector store implementations, the builder is provided as an inner class of the configuration. Why do you have it outside of GemFireVectorStoreConfig?
Contributor
|
@jhuynh1 As a general comment, please add your name as an author to all the classes you modified. |
sobychacko
added a commit
to sobychacko/spring-ai
that referenced
this pull request
Aug 22, 2024
- Based on the pattern established in other vector store support implementations, added a builder class as an inner class of the GemfireVectorStoreConfig class which is also moved as an inner class to GemfireVectorStore. Based on the original PR: spring-projects#1168
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added builder and moved config class as an inner class of GemFireVectorStore to match other vector store projects
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits