Prevent concurrent mutation in Google GenAI dimension lookup - #6769
Open
dangzitou wants to merge 1 commit into
Open
Prevent concurrent mutation in Google GenAI dimension lookup#6769dangzitou wants to merge 1 commit into
dangzitou wants to merge 1 commit into
Conversation
Signed-off-by: Dang Zitou <dengzitao888@163.com>
dangzitou
force-pushed
the
chore/fix-google-genai-dimension-cache
branch
from
August 7, 2026 17:34
49a1abc to
b63fec6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GoogleGenAiTextEmbeddingModel.dimensions()mutates a shared staticHashMap, throwingConcurrentModificationExceptionunder concurrent use #6763.GoogleGenAiTextEmbeddingModel.dimensions()no longer mutates the shared static lookup map when model is unknown.AbstractEmbeddingModelfallback path.Issue
Closes #6763
Change
The current
computeIfAbsentcall on a shared mutableHashMapcan throwConcurrentModificationExceptionunder concurrent access when multiple unknown model names are requested simultaneously. This change removes side-effectful map writes from the hot path by querying dimensions once and only assigning via the existing fallback path.Why
Validation
dimensions()branching.mvn test/ full project CI not run in this environment.