Expose getJobParameters to subclasses#231
Merged
Merged
Conversation
Member
|
The change looks good to me. Going forward, if there is a Jira issue, please use a feature branch named the same as the Jira issue (as you did in the batch-admin change related to this one). Merged. Thanks! |
Author
|
Thanks for merging! Should we backport this to the 2.2.x branch to be compatible with batch-admin? |
garyrussell
pushed a commit
to garyrussell/spring-batch
that referenced
this pull request
Jan 7, 2014
See https://jira.springsource.org/browse/BATCHADM-176 Must be applied after spring-projects#231 As part of this, I had to update the dependency on spring-batch to 3.0.0-BUILD_SNAPSHOT. Because of this dependency change, I had to add two methods to JobRepositorySupport. It looks like a stub class, so I left the two methods implemented as stubs.
mminella
pushed a commit
to mminella/spring-batch
that referenced
this pull request
Jan 7, 2014
See https://jira.springsource.org/browse/BATCHADM-176 Must be applied after spring-projects#231 As part of this, I had to update the dependency on spring-batch to 3.0.0-BUILD_SNAPSHOT. Because of this dependency change, I had to add two methods to JobRepositorySupport. It looks like a stub class, so I left the two methods implemented as stubs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
https://jira.springsource.org/browse/BATCHADM-176
There will be a corresponding pull request in batch admin to take advantage of this change.