Skip to content

PropertiesLauncher does not log nested archive paths - #50968

Merged
snicoll merged 2 commits into
spring-projects:4.0.xfrom
filiphr:properties-launcher-polish
Jul 21, 2026
Merged

PropertiesLauncher does not log nested archive paths#50968
snicoll merged 2 commits into
spring-projects:4.0.xfrom
filiphr:properties-launcher-polish

Conversation

@filiphr

@filiphr filiphr commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

I've been playing around with the PropertiesLauncher and I noticed then the logging looks like:

...PropertiesLauncher : Property 'loader.path'[Loader-Path]  from environment: WEB-INF/classes,WEB-INF/lib,WEB-INF/lib-provided,file:/dummy
...PropertiesLauncher : Nested archive paths: null
...PropertiesLauncher : Property 'loader.path'[Loader-Path]  from environment: WEB-INF/classes,WEB-INF/lib,WEB-INF/lib-provided,file:/dummy
...PropertiesLauncher : Nested archive paths: [WEB-INF/classes/, WEB-INF/lib/, WEB-INF/lib-provided/, file:/dummy/]

I was confused by

Nested archive paths: null

and that's how I realized that the logging is using this.paths always, and that this is the only place using the paths field.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 17, 2026
@snicoll snicoll changed the title Remove not used paths field from PropertiesLauncher PropertiesLauncher does not log nested archive paths Jul 20, 2026
@snicoll snicoll self-assigned this Jul 20, 2026
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 20, 2026
@snicoll snicoll added this to the 4.0.x milestone Jul 20, 2026
@snicoll
snicoll force-pushed the properties-launcher-polish branch from fc03a75 to 59de56d Compare July 21, 2026 13:16
@snicoll snicoll modified the milestones: 4.0.x, 4.0.8 Jul 21, 2026
@snicoll
snicoll changed the base branch from main to 4.0.x July 21, 2026 13:16
@snicoll
snicoll merged commit 3f48c2b into spring-projects:4.0.x Jul 21, 2026
3 of 4 checks passed
@filiphr
filiphr deleted the properties-launcher-polish branch July 22, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants