Disable Micrometer global registry in tests by default - #51142
Open
LordKay-sudo wants to merge 2 commits into
Open
Disable Micrometer global registry in tests by default#51142LordKay-sudo wants to merge 2 commits into
LordKay-sudo wants to merge 2 commits into
Conversation
Default management.metrics.use-global-registry to false in tests when unset, mirroring the Reactor global-resources customizer, so Micrometer does not pin cached application contexts. Follow-up to spring-projectsgh-50886 for main (4.2.x). Signed-off-by: LordKay-sudo <lkandiro@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Ensure files end with a newline for Checkstyle and expand unit tests around explicit property values, factory classpath gating, and equals/hashCode for context caching. Signed-off-by: LordKay-sudo <lkandiro@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #50886 / @mhalbritter's request: land the deferred test-only change on
main(4.2.x).DisableGlobalMeterRegistryContextCustomizerFactoryso tests defaultmanagement.metrics.use-global-registry=falsewhen unsetmanagement.metrics.use-global-registryvalues untouchedThis is intentionally separate from the
MeterRegistryCloserfix already merged into4.0.x.Test plan
./gradlew :core:spring-boot-test:test --tests DisableGlobalMeterRegistryContextCustomizerFactoryTests