Correct exception type documented by resolveConfigLocation - #51175
Merged
snicoll merged 2 commits intoAug 5, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: task
The javadoc promises an IllegalArgumentException, but the method asserts with Assert.state, which throws an IllegalStateException. See spring-projectsgh-51175 Signed-off-by: wantaek <wantaekchoi@gmail.com>
This removes the throws entry altogether as we don't usually document such exception. See spring-projectsgh-51175
snicoll
force-pushed
the
fix/hazelcast-resolve-config-location-throws
branch
from
August 5, 2026 09:38
dc5a468 to
481f6f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HazelcastProperties.resolveConfigLocationdocuments@throws IllegalArgumentException, but it asserts withAssert.state, which throwsIllegalStateException. Spring Framework's own javadoc onAssert.statesays as much, and points atisTruefor theIllegalArgumentExceptioncase.