Skip to content

Conversation

@loupXing
Copy link

@loupXing loupXing commented Dec 11, 2018

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@xhaggi
Copy link
Contributor

xhaggi commented Dec 18, 2018

Before we can accept your contribution you have to read our Spring Data contribution guidelines carefully and file an issue to our JIRA.

@loupXing loupXing closed this Dec 19, 2018
@loupXing loupXing reopened this Dec 19, 2018
@pnowak85
Copy link
Contributor

This PR would also fix the bug described in DATAES-525, but the main problem is the doScroll (see DATAES-525).
I think instead of adding the filter clause the root issue should be fixed and also this change would make the ElasticsearchRestTemplate behave differently than the ElasticsearchTemplate.

I have made a Pull Request which fixes the doScroll method and thereby resolving the deletion issue which should make this PR obsolete.

@xhaggi xhaggi closed this Feb 14, 2019
@xhaggi
Copy link
Contributor

xhaggi commented Feb 14, 2019

Superseded by #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants