DATAES-525 - Fixed doScroll() method which caused the deletion issues. #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pnowak85
commented
Jan 25, 2019
pnowak85
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
5 tasks
Contributor
|
@pnowak85 thank you for your contribution. Please squash your commits into a single one. |
xhaggi
approved these changes
Feb 14, 2019
The root cause of the deletion problem was the doScroll which did not apply the given query and therefor returned all entries from the index. The doScroll implementation has been fixed to apply the query and multiple unit tests have been added to ensure that the delete methods delete the desired documents only and leave the rest untouched. Also added unit tests for the scrolling to test it against real queries (not only matchAll).
Contributor
Author
|
@xhaggi squash commit done |
xhaggi
pushed a commit
that referenced
this pull request
Feb 21, 2019
The root cause of the deletion problem was the doScroll which did not apply the given query and therefor returned all entries from the index. The doScroll implementation has been fixed to apply the query and multiple unit tests have been added to ensure that the delete methods delete the desired documents only and leave the rest untouched. Also added unit tests for the scrolling to test it against real queries (not only matchAll). Original pull request: #240
Contributor
|
@pnowak85 Thank you. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.