Skip to content

Fix Sort.by for embeddables #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Sort.by for embeddables #1403

wants to merge 1 commit into from

Conversation

@mipo256
Copy link
Contributor

@mipo256 mipo256 commented Jan 3, 2023 •
edited by schauder
Loading

Fixes GH-1286

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 3, 2023
@schauder
Copy link
Contributor

schauder commented Jan 4, 2023

You posted this as a draft. Please give us a quick outline what is missing from you perspective.

@schauder schauder linked an issue Jan 4, 2023 that may be closed by this pull request
Spring Data JDBC - Sort.by does not work on @Embedded property #1286
Closed
@mipo256
Copy link
Contributor Author

mipo256 commented Jan 4, 2023 •
edited
Loading

Hi Jens!
Everything is good, I am just trying to make it work also if the column name includes a dot.

You see, now in the code I am making an assumption, that if there is a dot in the name of the property, then it is the embedded property that we should look at. As far as I know some databases allow creation of columns with dots inside the name (At least it could be possible for delimited SQL identifiers). In my PR this case is not though through, so I am just trying to make it work as well.

This is almost done, I guess I will finish it today

@mipo256 mipo256 force-pushed the GH-1286 branch 3 times, most recently from b8163ca to 8c53ddf Compare January 27, 2023 07:53
@mipo256 mipo256 mentioned this pull request Jan 27, 2023
Closed
@mipo256 mipo256 marked this pull request as ready for review January 27, 2023 07:55
@mipo256 mipo256 force-pushed the GH-1286 branch 3 times, most recently from 8cdf080 to 2468208 Compare January 27, 2023 08:14
@mipo256
Copy link
Contributor Author

mipo256 commented Jan 27, 2023

After the PR #1415 get merged, I have moved this PR from Draft status and it is ready for review now.

@mipo256 mipo256 mentioned this pull request Jan 27, 2023
Closed
@mipo256 mipo256 force-pushed the GH-1286 branch 2 times, most recently from 1338abe to 23e6eb0 Compare January 27, 2023 13:00
@mipo256 mipo256 requested a review from schauder January 28, 2023 12:38
@schauder schauder changed the title GH-1286 Fix Sort.by for embeddables Jan 30, 2023
schauder pushed a commit that referenced this pull request Jan 30, 2023
@schauder
Support of embedded properties in Sort.by.
8eb80af 
Original pull request #1403
Closes #1286
schauder added a commit that referenced this pull request Jan 30, 2023
@schauder
Polishing.
c5c60da 
Original pull request #1403
See #1286
@schauder
Copy link
Contributor

schauder commented Jan 30, 2023

Thanks, this has been polished and merged.

@schauder schauder closed this Jan 30, 2023
@mipo256 mipo256 mentioned this pull request Feb 28, 2023
Closed
@schauder schauder added the type: enhancement A general enhancement label Feb 28, 2023
@schauder schauder added this to the 3.1 M2 (2023.0.0) milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schauder schauder Awaiting requested review from schauder

Assignees

No one assigned

Labels

status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Projects

None yet

Milestone

3.1 M2 (2023.0.0)

Development

Successfully merging this pull request may close these issues.

Spring Data JDBC - Sort.by does not work on @Embedded property

3 participants

@mipo256 @schauder @spring-projects-issues