DATAJDBC-584 - Allow sort by entity's child field #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DATAJDBC-561 - Fix link to code of conduct.
DATAJDBC-586 - Guard JdbcRepositoryFactoryBean against setting null values for properties
…nverter in FindAllByPath
…ustom converter in FindAllByPath" This reverts commit f408369.
schauder
requested changes
Oct 28, 2020
Contributor
schauder
left a comment
schauder
left a comment
There was a problem hiding this comment.
Apart from the inline comment I'd like to see integration tests, demonstrating that it
- works for 1:1 references
- for embedded references.
and a tests ensuring it produces a sensible exception when one tried to use on non existing properties or one-to-many properties.
| } | ||
|
|
||
| @Test // DATAJDBC-101 | ||
| @Test // DATAJDBC-101, DATAJDBC-584 |
Contributor
There was a problem hiding this comment.
I'd prefer to have a separate test case for this. It makes it easier to understand what is going wrong in case of a test failure.
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
@schauder I think we can close this PR, this issue have been already solved by this PR |
Contributor
|
I think you are right. |
schauder
added
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sort to accept entity's child field. eg: person.address.zipCode