Skip to content

DATAREST-2087 Add support of path on RepositoryRestController #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DATAREST-2087 Add support of path on RepositoryRestController #2088

wants to merge 1 commit into from

Conversation

@yyvess
Copy link
Contributor

@yyvess yyvess commented Nov 19, 2021

Fix #2087

Add a field "path/value" on the annotation @RepositoryRestController to be able to set a root path at class level.

@pivotal-cla
Copy link

pivotal-cla commented Nov 19, 2021

@yyvess Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

pivotal-cla commented Nov 19, 2021

@yyvess Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 19, 2021
@yyvess yyvess force-pushed the feature/RepositoryBasePath branch from f34e18a to 0111399 Compare November 19, 2021 08:40
@alienisty
Copy link

alienisty commented Nov 22, 2021

@RequestMappig supports an array of paths so I believe we should do the same for @RepositoryRestController

alienisty
alienisty reviewed Nov 22, 2021
View reviewed changes
...rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/RepositoryRestController.java Outdated
String value() default "";

@AliasFor("value")
String path() default "";
Copy link

@alienisty alienisty Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RequestMapping allows specifying more than one path, should we do the same here?

Copy link
Contributor Author

@yyvess yyvess Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alienisty I agree, I just update it

@yyvess yyvess force-pushed the feature/RepositoryBasePath branch from 0111399 to 7e18b17 Compare November 22, 2021 16:29
@sambernet sambernet mentioned this pull request Apr 26, 2022
Closed
@gauravbrills
Copy link

gauravbrills commented May 27, 2022

Hope this gets merged soon been a long time . For now we had to do a lot of refactor to avoid this in our latest migration :|

@abtabhi
Copy link

abtabhi commented Jun 2, 2022

can we please triage this

@zampettim
Copy link

zampettim commented Jun 15, 2022

We are definitely running into this issue as well, and we have a ton of AbstractControllers with a lot of methods that we inherit. Gettting this fix into the 2.7.x line of Spring Boot would be extremely helpful.

odrotbohm pushed a commit that referenced this pull request Jul 6, 2022
@yyvess @odrotbohm
Add support for controller base path on BasePathAwareController / Rep…
c73d381 
…ositoryRestController.

This commit introduces support for a common base path shared amongst all handler methods of a controller annotated with @BasePathAwareController / @RepositoryRestController.

Related ticket: #2087
Original pull request: #2088.
odrotbohm added a commit that referenced this pull request Jul 6, 2022
@odrotbohm
Polishing.
86ff61c 
Added test case and re-enabled the base URI to be prepended even in case a controller path prefix is configured. That functionality had been lost with the originally submitted changes.

Related ticket: #2087
Original pull request: #2088.
odrotbohm pushed a commit that referenced this pull request Jul 6, 2022
@yyvess @odrotbohm
Add support for controller base path on BasePathAwareController / Rep…
8daacad 
…ositoryRestController.

This commit introduces support for a common base path shared amongst all handler methods of a controller annotated with @BasePathAwareController / @RepositoryRestController.

Related ticket: #2157
Original pull request: #2088.
odrotbohm added a commit that referenced this pull request Jul 6, 2022
@odrotbohm
Polishing.
07ebc50 
Added test case and re-enabled the base URI to be prepended even in case a controller path prefix is configured. That functionality had been lost with the originally submitted changes.

Related ticket: #2157
Original pull request: #2088.
@yyvess
Copy link
Contributor Author

yyvess commented Aug 4, 2022 •
edited
Loading

Commit of this PR was cherry-pick to main branch (Spring data version 4.0.0-M5)

@yyvess yyvess closed this Oct 21, 2022
@yyvess
Copy link
Contributor Author

yyvess commented Oct 21, 2022

Merged by cherry-pick

@yyvess yyvess deleted the feature/RepositoryBasePath branch October 21, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alienisty alienisty alienisty left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature regression : Spring Data REST controller must not use @RequestMapping on class level as this would cause double registration with Spring MVC

7 participants

@yyvess @pivotal-cla @alienisty @gauravbrills @abtabhi @zampettim @spring-projects-issues