Updated as per standard design practice #25487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this class would be used in other Comparators, we should make this as singleton design pattern. I have just modified this class, so that it can be used in concurrent environments.
spring-projects-issues
added
the
status: waiting-for-triage
wind57
reviewed
Jul 28, 2020
spring-core/src/main/java/org/springframework/util/comparator/ComparableComparator.java
Outdated
Show resolved
Hide resolved
wind57
reviewed
Aug 2, 2020
spring-core/src/main/java/org/springframework/util/comparator/ComparableComparator.java
Show resolved
Hide resolved
Author
|
Hi, @jhoeller please review my PR, please give suggestions and merge this if its okay. |
Member
|
Thank you for the PR but there is nothing wrong with the current code. Changing the visibility of the default instance to |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this class would be used in other Comparators, we should make this as singleton design pattern. I have just modified this class, so that it can be used in concurrent environments.