Add logging operators in DefaultExchangeFunction only when debug is enabled - #37095
Merged
bclozel merged 1 commit intoAug 5, 2026
Conversation
samueldlightfoot
force-pushed
the
perf/exchange-functions-debug-gating
branch
from
July 30, 2026 19:05
dcc7871 to
5a3f11f
Compare
spring-projects-issues
added
the
status: waiting-for-triage
Prior to this commit, `DefaultExchangeFunction.exchange` added logging operations within `doOnRequest`/`doOnCancel` operators unconditionally, which costs two subscriber wrappers per request even though the log message construction itself is already guarded lazily. This commit gates the operators on `isDebugEnabled()`, checked per exchange so runtime log level changes are still honored. Signed-off-by: samlightfoot <samueldlightfoot@gmail.com>
bclozel
force-pushed
the
perf/exchange-functions-debug-gating
branch
from
August 5, 2026 15:00
5a3f11f to
595c246
Compare
bclozel
added
in: web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultExchangeFunction.exchange added doOnRequest/doOnCancel logging operators unconditionally, which costs two subscriber wrappers per request even though the log message construction itself is already guarded lazily. Gate the operators on isDebugEnabled(), checked per exchange so runtime log level changes are still honored.