IntegrationEvaluationContextAware.setIntegrationEvaluationContext() invoked after afterPropertiesSet() [INT-3749]

[spring-operator]

Marius Bogoevici opened INT-3749 and commented

Beans implementing IntegrationEvaluationContextAware will expect that the IntegrationEvaluationContext is set as part of the bean initialization process.

Due to the current approach of setting the context only in IntegrationEvaluationContextAwareBeanPostProcessor#afterSingletonsInstantiated, afterPropertiesSet() is called before the initialization takes place.

Reconsider the current approach, to reconcile the need for preventing early BeanFactory access with the expectations of InitializingBean

---

Affects: 4.2 M1

Issue Links:

• INTEXT-175 Upgrading to SI 4.2 causes KafkaProducingMessageHandler initialization to fail

• Some components trigger BeanPostProcessorChecker warning "is not eligible for getting processed by all BeanPostProcessors" [INT-3640] #7602 Some components trigger BeanPostProcessorChecker warning "is not eligible for getting processed by all BeanPostProcessors"

Referenced from: pull request #1482

[spring-operator]

Artem Bilan commented

The way to fix it is in the DelayHandler.onInit():

this.evaluationContext = ExpressionUtils.createStandardEvaluationContext(this.getBeanFactory());

It is safe, because "early BeanFactory access" issue appears only from BeanPostProcessor implementations.
Any afterPropertiesSet() is invoked when all BeanPostProcessor have been populated to the application context already.

[spring-operator]

Artem Bilan commented

This is the story of #7602

[spring-operator]

Artem Bilan commented

The second PR on the matter: #1486

[spring-operator]

Gary Russell commented

Merged