Support for PubSub Lock on AWS Elasticache Valkey #10473
Conversation
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Please, add DCO into your commit message before we start reviewing: https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring.
Thanks
Done! |
...ration-redis/src/main/java/org/springframework/integration/redis/util/RedisLockRegistry.java
Outdated
Show resolved
Hide resolved
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
This looks more closer to what I won't worry about 😄 .
If you confirm that this works with Valkey, please, add your name to the @author list of the changed class.
Please, also rebase your branch (and re-push to PR) to the latest main as I've just pushed the fix Redis tests according to the latest Spring Data Redis.
Thanks
…ontrol cluster slot hashing As a consequence, change the ChannelTopic to a PatternTopic to keep receiving subscription events for PubSub lock Signed-off-by: Severin Kistler <kistlerseverin@gmail.com>
…f `ARGV[2]` as values used as keys should be passed as such Signed-off-by: Severin Kistler <kistlerseverin@gmail.com>
|
According to my tests against valkey this is working. |
...ration-redis/src/main/java/org/springframework/integration/redis/util/RedisLockRegistry.java
Show resolved
Hide resolved
|
thank you for contribution; looking forward for more! |
2 participants
This is an attempt to make issue #10471 work without support for
SPUBLISH.I append the
lockKeyto thechannelUnlockKey. This allows us to control the cluster slot cache this operation is hashed into, by including a hash tag ({...}) in thelockKey. Refer to the issue description for an explanation of why this matters.As a consequence, I had to change the
ChannelTopicto aPatternTopicto keep receiving subscription events for the PubSub lock.