Skip to content

Fix typo in message ID generation section#11014

Merged
artembilan merged 1 commit into
spring-projects:mainfrom
mjd507:doc-msg-id
May 26, 2026
Merged

Fix typo in message ID generation section#11014
artembilan merged 1 commit into
spring-projects:mainfrom
mjd507:doc-msg-id

Conversation

@mjd507
Copy link
Copy Markdown
Contributor

@mjd507 mjd507 commented May 23, 2026

No description provided.

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@mjd507
Copy link
Copy Markdown
Contributor Author

mjd507 commented May 23, 2026

I have a doubt

The idGenerator field in MessageHeaders looks always null, and no static setIdGenerator method provided.

but the static getGenerator method will check this null idGenerator first, then the default-idGenerator.

I see in spring integration, our IdGeneratorConfigurer will use reflection to set this idGenerator field.

is it intentional, what's the harm if we add a static setIdGenerator method.

@artembilan
Copy link
Copy Markdown
Member

what's the harm if we add a static setIdGenerator method.

That is totally different story from what you have just fixed here.
I cannot answer you to that question because that was done before me.
You can raise a GH issue in the https://github.com/spring-projects/spring-framework with that question and proposal.
Doesn't look like it really comes with the harm: if we can do that via reflection, that means users of the framework can do that, too.

@artembilan artembilan added this to the 7.1.0 milestone May 26, 2026
@artembilan artembilan merged commit 8dc03fc into spring-projects:main May 26, 2026
3 checks passed
@mjd507 mjd507 deleted the doc-msg-id branch May 26, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants