INT-3664: Rework BPP stuff in the IntMBExporter
#1399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-3664 Since all metrics are already direct for the integration components, we don't do any proxying from `IntegrationMBeanExporter`, and even any other adjustments during BPP phases. Hence this stuff is already redundant for `IntegrationMBeanExporter`. In addition this change fix the `early access to the BeanFactory from BPP` issue.
There was a problem hiding this comment.
Needs try...catch like super.
|
Otherwise LGTM; I wonder if we should add a test to reload the same context in the same jvm to make sure all beans are unregistered (we probably should have had one with Lifecycle). Also, we should add a bullet to the new JMX section in the reference to say that the IMBE no longer implements Lifecycle etc. |
|
Pushed |
|
LGTM; doc polish here garyrussell@27b4ec3 I don't think we need to get into framework internals there (BPP etc). |
…istrationDelegate$BeanPostProcessorChecker`
|
Polishing accepted and pushed the fix according https://jira.spring.io/browse/SPR-12761 changes. |
|
Rebased; merged as 0f05512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3664
Since all metrics are already direct for the integration components, we don't do any proxying from
IntegrationMBeanExporter,and even any other adjustments during BPP phases. Hence this stuff is already redundant for
IntegrationMBeanExporter.In addition this change fix the
early access to the BeanFactory from BPPissue.