INT-3663: Fix early BF access for Security Module #1406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need some polishing, JavaDocs and Docs. |
|
@garyrussell , let me know if you are OK with the solution and I go ahead for docs. |
There was a problem hiding this comment.
WARN: serialVersionUID
|
Otherwise LGTM |
JIRA: https://jira.spring.io/browse/INT-3663 Previously the `ChannelSecurityInterceptorBeanPostProcessor` was populated with direct `BeanDefinition`s for `ChannelSecurityInterceptor`s. It caused an `early access to BeanFactory`. The issue has been introduced by the `ChannelSecurityInterceptorFactoryBean` * Rework `SecurityIntegrationConfigurationInitializer` do not populate `BeanDefinition`s to the `ChannelSecurityInterceptorBeanPostProcessor`, but just `bean names` * Redesign `ChannelSecurityInterceptorBeanPostProcessor` to the `AbstractAutoProxyCreator` * Introduce `SecuredChannel` annotation to be used on the `@Bean` level for `MessageChannel` definition * Move `access policy` mapping to the `SecuredChannel` annotation
|
Pushed |
|
LGTM; still needs docs etc, though; right? |
|
Yeah... Sure! At least say that we did a deprecation and add a couple samples with JavaConfig |
|
Pushed documentation. |
|
Merged as b6cfd4f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3663
Previously the
ChannelSecurityInterceptorBeanPostProcessorwas populated with directBeanDefinitions forChannelSecurityInterceptors.It caused an
early access to BeanFactory.The issue has been introduced by the
ChannelSecurityInterceptorFactoryBeanSecurityIntegrationConfigurationInitializerdo not populateBeanDefinitions to theChannelSecurityInterceptorBeanPostProcessor, but justbean namesChannelSecurityInterceptorBeanPostProcessorto theAbstractAutoProxyCreatorSecuredChannelannotation to be used on the@Beanlevel forMessageChanneldefinitionaccess policymapping to theSecuredChannelannotation