fix: register the HAL beans when HateoasProperties is absent - #3343
Merged
Conversation
Requiring HateoasProperties on the classpath disabled the whole hateoas configuration for applications that only depend on spring-boot-starter-data-rest, since HateoasProperties lives in the separate spring-boot-hateoas auto-configuration module. Without CollectionModelContentConverter the _embedded schema was left without properties and /v3/api-docs failed with a NullPointerException. Restore the LinkRelationProvider-only class condition and pick the HateoasHalProvider bean definition through nested configurations, and guard the data-rest schema post-processing against empty properties. Fixes #3328 Fixes #3337 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requiring
HateoasPropertieson the classpath disabled the whole hateoas configuration for applications that only depend onspring-boot-starter-data-rest, sinceHateoasPropertieslives in the separatespring-boot-hateoasauto-configuration module. WithoutCollectionModelContentConverterthe_embeddedschema was left without properties and/v3/api-docsfailed with aNullPointerException.Restore the
LinkRelationProvider-only class condition and pick theHateoasHalProviderbean definition through nested configurations, and guard the data-rest schema post-processing against empty properties.Fixes #3328
Fixes #3337