fix: read the OAS 3.1 type back for every schema subclass - #3344
Merged
Conversation
The type deserializer was only registered for JsonSchema, so cloning any other schema subclass still failed and logged a Json Processing Exception warning for every constrained parameter. Extend the swagger-core mixin so that it can be registered on Schema itself without dropping the serialization it declares, register it on the standalone mappers too, and carry the deserializer over to the sorting mixin that replaces it. Fixes #3314 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type deserializer was only registered for
JsonSchema, so cloning any other schema subclass still failed and logged aJson Processing Exceptionwarning for every constrained parameter.Extend the swagger-core mixin so that it can be registered on
Schemaitself without dropping the serialization it declares, register it on the standalone mappers too, and carry the deserializer over to the sorting mixin that replaces it.Follow-up to #3315.
Fixes #3314