Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

feat: enable user to specify wallets#161

Merged
mpetrunic merged 17 commits intodevfrom
feat/enable_adding_other_web3_wallets
Apr 11, 2024
Merged

feat: enable user to specify wallets#161
mpetrunic merged 17 commits intodevfrom
feat/enable_adding_other_web3_wallets

Conversation

@saadahmsiddiqui
Copy link
Copy Markdown
Contributor

@saadahmsiddiqui saadahmsiddiqui commented Apr 3, 2024

Add functionality to enable users to specify onboard.js wallet modules

Description

Add Widget property wallets that accepts list of WalletInit[] objects from 3rd party app

Related Issue Or Context

Enable adding other web3 wallets

Closes: #87

Types of changes

  • WalletController now supports ability to specify onboard wallets

@wainola
Copy link
Copy Markdown
Contributor

wainola commented Apr 4, 2024

@saadjhk you are missing some changes that we currently have on main for the wallet context and the manger mainly. connectEvmWallet receives and object for walletConnectOptions as well as appMetadata. You can find those on main branch. In that case it would make sense to rebase from main 😄

mpetrunic
mpetrunic previously approved these changes Apr 10, 2024
Co-authored-by: Filip Štoković <59089574+sztok7@users.noreply.github.com>
@mpetrunic mpetrunic merged commit d285f95 into dev Apr 11, 2024
@mpetrunic mpetrunic deleted the feat/enable_adding_other_web3_wallets branch April 11, 2024 07:06
Lykhoyda pushed a commit that referenced this pull request Apr 15, 2024
Add functionality to enable users to specify `onboard.js` wallet modules

## Description

Add Widget property `wallets` that accepts list of `WalletInit[]`
objects from 3rd party app

## Related Issue Or Context

[Enable adding other web3
wallets](#87)

Closes: #87

## Types of changes

- [x] `WalletController` now supports ability to specify onboard wallets

---------

Co-authored-by: Filip Štoković <59089574+sztok7@users.noreply.github.com>
mpetrunic pushed a commit that referenced this pull request May 7, 2024
Add functionality to enable users to specify `onboard.js` wallet modules

## Description

Add Widget property `wallets` that accepts list of `WalletInit[]`
objects from 3rd party app

## Related Issue Or Context

[Enable adding other web3
wallets](#87)

Closes: #87

## Types of changes

- [x] `WalletController` now supports ability to specify onboard wallets

---------

Co-authored-by: Filip Štoković <59089574+sztok7@users.noreply.github.com>
@MakMuftic MakMuftic mentioned this pull request May 7, 2024
MakMuftic added a commit that referenced this pull request Jun 13, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@buildwithsygma/sygmaprotocol-react-widget:
0.1.3</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @buildwithsygma/sygmaprotocol-widget bumped to 0.2.0
</details>

<details><summary>sygmaprotocol-widget: 0.2.0</summary>

##
[0.2.0](sygmaprotocol-widget-v0.1.2...sygmaprotocol-widget-v0.2.0)
(2024-06-13)


### Features

* automatically add unknown source evm network into wallet
([#162](#162))
([d5886bd](d5886bd))
* display amount to be received on destination
([#168](#168))
([347f7a5](347f7a5))
* Display Fee
([#145](#145))
([872703d](872703d))
* display transfer gas cost estimation
([#174](#174))
([b154555](b154555))
* enable developers to configure network whitelisting
([#170](#170))
([5db505f](5db505f))
* enable user to specify wallets
([#161](#161))
([8a02170](8a02170))
* Retry loading bridge routes
([#136](#136))
([8e0101f](8e0101f))
* substrate fungible transfer
([#134](#134))
([337f1b7](337f1b7))
* wallet account selector for substrate
([#106](#106))
([79127fd](79127fd)),
closes [#74](#74)


### Bug Fixes

* amount to receive
([#196](#196))
([8c2cdad](8c2cdad))
* destination address format
([#197](#197))
([250ea35](250ea35))
* explorer urls when adding networks
([#200](#200))
([d65d99a](d65d99a))
* Fixed amount to receive decimals
([#208](#208))
([be23500](be23500))
* Gas Fee estimation behavior, is not consistent for the actual transfer
TX ([#204](#204))
([d57233e](d57233e))
* handling transfer cancellation on substrate
([#195](#195))
([6ce25cb](6ce25cb))
* resource name
([#201](#201))
([1215dcc](1215dcc))
* resource selector
([#199](#199))
([81bae38](81bae38))
* small fix for tangle connection
([#212](#212))
([557d71e](557d71e))
* source switch reset
([#206](#206))
([1b1f92c](1b1f92c)),
closes [#205](#205)
* typesafety when handling changed properties
([#141](#141))
([692e269](692e269))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants