Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

fix: resource name#201

Merged
wainola merged 6 commits intomainfrom
fix/resource-name
May 28, 2024
Merged

fix: resource name#201
wainola merged 6 commits intomainfrom
fix/resource-name

Conversation

@wainola
Copy link
Copy Markdown
Contributor

@wainola wainola commented May 23, 2024

Description

Add elipsis and overflow is resource name is too long

Related Issue Or Context

Closes: #188

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

LyonSsS
LyonSsS previously approved these changes May 28, 2024
Copy link
Copy Markdown

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on the Preview Link and is displayed correctly

@Lykhoyda
Copy link
Copy Markdown
Contributor

@wainola "select token" has jumped to the second line. Can you please fix it as well?

Screenshot 2024-05-28 at 16 18 00

LyonSsS
LyonSsS previously approved these changes May 28, 2024
Copy link
Copy Markdown

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested on the latest preview link and works as expected

@wainola
Copy link
Copy Markdown
Contributor Author

wainola commented May 28, 2024

@wainola "select token" has jumped to the second line. Can you please fix it as well?

Screenshot 2024-05-28 at 16 18 00

done

@wainola wainola merged commit 1215dcc into main May 28, 2024
@wainola wainola deleted the fix/resource-name branch May 28, 2024 16:23
@MakMuftic MakMuftic mentioned this pull request May 28, 2024
MakMuftic added a commit that referenced this pull request Jun 13, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@buildwithsygma/sygmaprotocol-react-widget:
0.1.3</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @buildwithsygma/sygmaprotocol-widget bumped to 0.2.0
</details>

<details><summary>sygmaprotocol-widget: 0.2.0</summary>

##
[0.2.0](sygmaprotocol-widget-v0.1.2...sygmaprotocol-widget-v0.2.0)
(2024-06-13)


### Features

* automatically add unknown source evm network into wallet
([#162](#162))
([d5886bd](d5886bd))
* display amount to be received on destination
([#168](#168))
([347f7a5](347f7a5))
* Display Fee
([#145](#145))
([872703d](872703d))
* display transfer gas cost estimation
([#174](#174))
([b154555](b154555))
* enable developers to configure network whitelisting
([#170](#170))
([5db505f](5db505f))
* enable user to specify wallets
([#161](#161))
([8a02170](8a02170))
* Retry loading bridge routes
([#136](#136))
([8e0101f](8e0101f))
* substrate fungible transfer
([#134](#134))
([337f1b7](337f1b7))
* wallet account selector for substrate
([#106](#106))
([79127fd](79127fd)),
closes [#74](#74)


### Bug Fixes

* amount to receive
([#196](#196))
([8c2cdad](8c2cdad))
* destination address format
([#197](#197))
([250ea35](250ea35))
* explorer urls when adding networks
([#200](#200))
([d65d99a](d65d99a))
* Fixed amount to receive decimals
([#208](#208))
([be23500](be23500))
* Gas Fee estimation behavior, is not consistent for the actual transfer
TX ([#204](#204))
([d57233e](d57233e))
* handling transfer cancellation on substrate
([#195](#195))
([6ce25cb](6ce25cb))
* resource name
([#201](#201))
([1215dcc](1215dcc))
* resource selector
([#199](#199))
([81bae38](81bae38))
* small fix for tangle connection
([#212](#212))
([557d71e](557d71e))
* source switch reset
([#206](#206))
([1b1f92c](1b1f92c)),
closes [#205](#205)
* typesafety when handling changed properties
([#141](#141))
([692e269](692e269))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token drop down field, display the drop down icon over the token name

4 participants