Fix invalid catalog after pbiazure:// to XMLA redirect - #970
Merged
Conversation
AdomdConnectionWrapper previously called ChangeDatabase() using the internal catalog name format (sobe_wowvirtualserver-<DBName>). Since AdomdClient 19.96.1, the Analyze-in-Excel to public XMLA redirect is no longer restricted to an application ID allow-list. As a result, opening a cloud dataset connection now transparently redirects from pbiazure:// to powerbi:// and updates the catalog to the dataset's display name. The subsequent explicit call to ChangeDatabase() sent the outdated catalog name to the XMLA endpoint, causing it to reject the connection as a non-existent database. ChangeDatabase() was redundant in both wrappers, as the catalog is already specified by the Initial Catalog connection string property. This call has been removed, and the effective catalog is now read directly from Connection.Database when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdomdConnectionWrapper previously called ChangeDatabase() using the internal catalog name format (sobe_wowvirtualserver-). Since AdomdClient 19.96.1, the Analyze-in-Excel to public XMLA redirect is no longer restricted to an application ID allow-list. As a result, opening a cloud dataset connection now transparently redirects from pbiazure:// to powerbi:// and updates the catalog to the dataset's display name. The subsequent explicit call to ChangeDatabase() sent the outdated catalog name to the XMLA endpoint, causing it to reject the connection as a non-existent database. ChangeDatabase() was redundant in both wrappers, as the catalog is already specified by the Initial Catalog connection string property. This call has been removed, and the effective catalog is now read directly from Connection.Database when needed.