Fix test GoldenFile.GetSnapshotPath under ContinuousIntegrationBuild#61
Merged
Conversation
Azure Pipelines' build step applies /p:ContinuousIntegrationBuild=true to every project (src/**/*.csproj), which makes Roslyn remap the [CallerFilePath] literal compiled into GoldenFile to a deterministic placeholder like "/_/src/Dax.Template.Tests/...". That path never exists on disk, so walking up from it to find the test project's .csproj always bottomed out at null and threw. Fall back to AppContext.BaseDirectory (the real runtime output directory, unaffected by compile-time path mapping) when the caller-path walk doesn't resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Pipelines' build step applies /p:ContinuousIntegrationBuild=true to every project (src/**/*.csproj), which makes Roslyn remap the [CallerFilePath] literal compiled into GoldenFile to a deterministic placeholder like "/_/src/Dax.Template.Tests/...". That path never exists on disk, so walking up from it to find the test project's .csproj always bottomed out at null and threw. Fall back to AppContext.BaseDirectory (the real runtime output directory, unaffected by compile-time path mapping) when the caller-path walk doesn't resolve.