gen: run each engine's dialect generation as a separate job - #4608
Merged
Conversation
The gen workflow generated every dialect in one job, so a failure in one engine hid the results of the others and the PostgreSQL service ran for engines that do not need it. Split it into one job per generated engine (postgresql, clickhouse, sqlite), each uploading its own artifact and checking only its own committed dialect. DuckDB has no CLI release to download yet, so it still has no job. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PDAdd694tS93jQsF4X5Hqb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
genworkflow generated every dialect in one job, so a failure in one engine hid the results of the others, and the PostgreSQL service container ran for engines that do not need it.This splits it into one job per generated engine:
goldeneye generate postgresql.Each job uploads its own artifact (
dialect-<engine>) and the "committed dialect differs" check is scoped to that engine's directory.DuckDB still has no job: the DuckDB 2.0 CLI goldeneye needs has no release to download yet, so the previous single job skipped it too.
Test plan
genworkflow on this branch and confirm all three jobs pass🤖 Generated with Claude Code
https://claude.ai/code/session_01PDAdd694tS93jQsF4X5Hqb
Generated by Claude Code