Fix Secondary Log Shipping Monitor#5764
Merged
potatoqualitee merged 3 commits intoprereleasefrom Jun 17, 2019
Merged
Conversation
Changed parameters to secondary monitor server variables
Changes fixes #5439
Member
|
this is gorgeous! thank you 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Purpose
When you assign a secondary monitor server, the command would not use that monitor server although it was set.
Approach
Somewhere along the way variables for the primary server were passed along to the internal log shipping command that also makes the changes for the secondary monitor.
Commands to test
Invoke-DbaDbLogShipping
Screenshots
I used two different values because I did not have enough resources to test this on two different instances.
I used "localhost" for the primary and my local hostname (IT-SStad-Mobile) as the secondary. Technically they're the same but the values should be represented differently
The right secondary server is used

The right secondary monitor server is passed
