Compile errors on Win32

[justinclift]

Just checked our build server, as the nightlies haven't run for a few days. It ran out of disk space, so VMware Fusion suspended the VMs! 😦

Manually running the Win32 build after freeing up disk space resulted in a failed build. Looks like we've introduced some errors in the last ~week since the build worked:

5>  sqlitetypes.cpp
5>sqlite3_parser.hpp(992): warning C4065: switch statement contains 'default' but no 'case' labels
5>  sqlite3_parser.hpp(983): note: while compiling class template member function 'void sqlb::parser::parser::basic_symb
ol<sqlb::parser::parser::by_type>::clear(void)'
5>  sqlite3_parser.hpp(978): note: see reference to function template instantiation 'void sqlb::parser::parser::basic_sy
mbol<sqlb::parser::parser::by_type>::clear(void)' being compiled
5>  sqlite3_parser.hpp(1240): note: see reference to class template instantiation 'sqlb::parser::parser::basic_symbol<sq
lb::parser::parser::by_type>' being compiled

...

5>  SelectItemsPopup.cpp
5>  TableBrowser.cpp
5>c:\git_repos\sqlitebrowser\src\TableBrowser.h(178): error C2039: 'function': is not a member of 'std'
5>  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\unordered_set(13): note: see declaration of 'std'
5>c:\git_repos\sqlitebrowser\src\TableBrowser.h(178): error C2061: syntax error: identifier 'function'
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(133): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(137): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(143): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(148): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(152): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(155): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(158): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(166): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(173): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(180): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(187): error C2660: 'TableBrowser::modifyColumnFormat': function does n
ot take 2 arguments
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(624): error C2511: 'void TableBrowser::modifyColumnFormat(std::unorder
ed_set<int,std::hash<int>,std::equal_to<_Kty>,std::allocator<_Ty>>,std::function<void (CondFormat &)>)': overloaded memb
er function not found in 'TableBrowser'
5>          with
5>          [
5>              _Kty=int,
5>              _Ty=int
5>          ]
5>  c:\git_repos\sqlitebrowser\src\TableBrowser.h(76): note: see declaration of 'TableBrowser'
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(626): error C2352: 'TableBrowser::currentlyBrowsedTableName': illegal
call of non-static member function
5>  C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(315): note: see declaration of 'TableBrowser::currentlyBrowsedTableN
ame'
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(626): error C2228: left of '.condFormats' must have class/struct/union

5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(626): error C2530: 'columnFormats': references must be initialized
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(633): error C2227: left of '->addCondFormat' must point to class/struc
t/union/generic type
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(639): error C2227: left of '->data' must point to class/struct/union/g
eneric type
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(639): error C2352: 'TableBrowser::currentIndex': illegal call of non-s
tatic member function
5>  C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(349): note: see declaration of 'TableBrowser::currentIndex'
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(639): error C2228: left of '.sibling' must have class/struct/union
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(639): error C2228: left of '.row' must have class/struct/union
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(640): error C2228: left of '.toInt' must have class/struct/union
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(642): error C2227: left of '->encoding' must point to class/struct/uni
on/generic type
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(648): error C2227: left of '->addCondFormat' must point to class/struc
t/union/generic type
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(649): error C2352: 'TableBrowser::currentlyBrowsedTableName': illegal
call of non-static member function
5>  C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(315): note: see declaration of 'TableBrowser::currentlyBrowsedTableN
ame'
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(649): error C2228: left of '.condFormats' must have class/struct/union

5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(649): error C2228: left of '.push_back' must have class/struct/union
5>C:\git_repos\sqlitebrowser\src\TableBrowser.cpp(652): error C2352: 'TableBrowser::projectModified': illegal call of no
n-static member function
5>  c:\git_repos\sqlitebrowser\src\TableBrowser.h(112): note: see declaration of 'TableBrowser::projectModified'
5>  ParserDriver.cpp
5>sqlite3_parser.hpp(992): warning C4065: switch statement contains 'default' but no 'case' labels
5>  sqlite3_parser.hpp(983): note: while compiling class template member function 'void sqlb::parser::parser::basic_symb
ol<sqlb::parser::parser::by_type>::clear(void)'
5>  sqlite3_parser.hpp(978): note: see reference to function template instantiation 'void sqlb::parser::parser::basic_sy
mbol<sqlb::parser::parser::by_type>::clear(void)' being compiled
5>  sqlite3_parser.hpp(1240): note: see reference to class template instantiation 'sqlb::parser::parser::basic_symbol<sq
lb::parser::parser::by_type>' being compiled
5>  sqlite3_lexer.cpp
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(48): warning C4005: 'INT8_MIN': macro redefini
tion
5>  sqlite3_lexer.cpp(83): note: see previous definition of 'INT8_MIN'
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(49): warning C4005: 'INT16_MIN': macro redefin
ition
5>  sqlite3_lexer.cpp(86): note: see previous definition of 'INT16_MIN'
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(50): warning C4005: 'INT32_MIN': macro redefin
ition
5>  sqlite3_lexer.cpp(89): note: see previous definition of 'INT32_MIN'
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(52): warning C4005: 'INT8_MAX': macro redefini
tion
5>  sqlite3_lexer.cpp(92): note: see previous definition of 'INT8_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(53): warning C4005: 'INT16_MAX': macro redefin
ition
5>  sqlite3_lexer.cpp(95): note: see previous definition of 'INT16_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(54): warning C4005: 'INT32_MAX': macro redefin
ition
5>  sqlite3_lexer.cpp(98): note: see previous definition of 'INT32_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(56): warning C4005: 'UINT8_MAX': macro redefin
ition
5>  sqlite3_lexer.cpp(101): note: see previous definition of 'UINT8_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(57): warning C4005: 'UINT16_MAX': macro redefi
nition
5>  sqlite3_lexer.cpp(104): note: see previous definition of 'UINT16_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\stdint.h(58): warning C4005: 'UINT32_MAX': macro redefi
nition
5>  sqlite3_lexer.cpp(107): note: see previous definition of 'UINT32_MAX'
5>sqlite3_parser.hpp(992): warning C4065: switch statement contains 'default' but no 'case' labels
5>  sqlite3_parser.hpp(983): note: while compiling class template member function 'void sqlb::parser::parser::basic_symb
ol<sqlb::parser::parser::by_type>::clear(void)'
5>  sqlite3_parser.hpp(978): note: see reference to function template instantiation 'void sqlb::parser::parser::basic_sy
mbol<sqlb::parser::parser::by_type>::clear(void)' being compiled
5>  sqlite3_parser.hpp(1240): note: see reference to class template instantiation 'sqlb::parser::parser::basic_symbol<sq
lb::parser::parser::by_type>' being compiled
5>  sqlite3_parser.cpp
5>sqlite3_parser.hpp(992): warning C4065: switch statement contains 'default' but no 'case' labels
5>  sqlite3_parser.hpp(983): note: while compiling class template member function 'void sqlb::parser::parser::basic_symb
ol<sqlb::parser::parser::by_type>::clear(void)'
5>  sqlite3_parser.cpp(3139): note: see reference to function template instantiation 'void sqlb::parser::parser::basic_s
ymbol<sqlb::parser::parser::by_type>::clear(void)' being compiled
5>  sqlite3_parser.hpp(1240): note: see reference to class template instantiation 'sqlb::parser::parser::basic_symbol<sq
lb::parser::parser::by_type>' being compiled
5>  qrc_icons.cpp
5>  qrc_flags.cpp
5>  qrc_translations.cpp
5>  qrc_CaCerts.cpp
5>  Generating Code...
5>c:\git_repos\sqlitebrowser\src\condformat.cpp(150): warning C4715: 'CondFormat::alignmentFlag': not all control paths
return a value
5>c:\git_repos\sqlitebrowser\src\condformat.cpp(15): warning C4715: 'CondFormat::fromCombinedAlignment': not all control
 paths return a value
5>  Compiling...
5>  qrc_style.cpp

[justinclift]

Interestingly, the Win64 build succeeds, though it displays some of the same warnings:

5>ParserDriver.cpp
5>sqlite3_parser.hpp(992): warning C4065: switch statement contains 'default' but no 'case' labels
5>sqlite3_parser.hpp(983): note: while compiling class template member function 'void sqlb::parser::parser::basic_symbol
<sqlb::parser::parser::by_type>::clear(void)'
5>sqlite3_parser.hpp(978): note: see reference to function template instantiation 'void sqlb::parser::parser::basic_symb
ol<sqlb::parser::parser::by_type>::clear(void)' being compiled
5>sqlite3_parser.hpp(1240): note: see reference to class template instantiation 'sqlb::parser::parser::basic_symbol<sqlb
::parser::parser::by_type>' being compiled
5>sqlite3_lexer.cpp
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(48): warning
C4005: 'INT8_MIN': macro redefinition
5>sqlite3_lexer.cpp(83): note: see previous definition of 'INT8_MIN'
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(49): warning
C4005: 'INT16_MIN': macro redefinition
5>sqlite3_lexer.cpp(86): note: see previous definition of 'INT16_MIN'
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(50): warning
C4005: 'INT32_MIN': macro redefinition
5>sqlite3_lexer.cpp(89): note: see previous definition of 'INT32_MIN'
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(52): warning
C4005: 'INT8_MAX': macro redefinition
5>sqlite3_lexer.cpp(92): note: see previous definition of 'INT8_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(53): warning
C4005: 'INT16_MAX': macro redefinition
5>sqlite3_lexer.cpp(95): note: see previous definition of 'INT16_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(54): warning
C4005: 'INT32_MAX': macro redefinition
5>sqlite3_lexer.cpp(98): note: see previous definition of 'INT32_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(56): warning
C4005: 'UINT8_MAX': macro redefinition
5>sqlite3_lexer.cpp(101): note: see previous definition of 'UINT8_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(57): warning
C4005: 'UINT16_MAX': macro redefinition
5>sqlite3_lexer.cpp(104): note: see previous definition of 'UINT16_MAX'
5>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\stdint.h(58): warning
C4005: 'UINT32_MAX': macro redefinition
5>sqlite3_lexer.cpp(107): note: see previous definition of 'UINT32_MAX'
5>sqlite3_parser.hpp(992): warning C4065: switch statement contains 'default' but no 'case' labels
5>sqlite3_parser.hpp(983): note: while compiling class template member function 'void sqlb::parser::parser::basic_symbol
<sqlb::parser::parser::by_type>::clear(void)'
5>sqlite3_parser.hpp(978): note: see reference to function template instantiation 'void sqlb::parser::parser::basic_symb
ol<sqlb::parser::parser::by_type>::clear(void)' being compiled
5>sqlite3_parser.hpp(1240): note: see reference to class template instantiation 'sqlb::parser::parser::basic_symbol<sqlb
::parser::parser::by_type>' being compiled
5>sqlite3_parser.cpp
5>sqlite3_parser.hpp(992): warning C4065: switch statement contains 'default' but no 'case' labels
5>sqlite3_parser.hpp(983): note: while compiling class template member function 'void sqlb::parser::parser::basic_symbol
<sqlb::parser::parser::by_type>::clear(void)'
5>sqlite3_parser.cpp(3139): note: see reference to function template instantiation 'void sqlb::parser::parser::basic_sym
bol<sqlb::parser::parser::by_type>::clear(void)' being compiled
5>sqlite3_parser.hpp(1240): note: see reference to class template instantiation 'sqlb::parser::parser::basic_symbol<sqlb
::parser::parser::by_type>' being compiled
5>qrc_icons.cpp
5>qrc_flags.cpp

[justinclift]

As a data point, this kind of thing has been showing up on the mac builds for a while. Doesn't seem to be breaking things though:

cd libs/qscintilla/Qt4Qt5/ && ( test -e Makefile.qscintilla || /Users/jc/Qt/5.11.3/clang_64/bin/qmake -o Makefile.qscintilla /Users/jc/git_repos/sqlitebrowser/libs/qscintilla/Qt4Qt5/qscintilla.pro -spec macx-clang CONFIG+=x86_64 ) && /Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile.qscintilla 
cd libs/qhexedit/ && ( test -e Makefile || /Users/jc/Qt/5.11.3/clang_64/bin/qmake -o Makefile /Users/jc/git_repos/sqlitebrowser/libs/qhexedit/qhexedit.pro -spec macx-clang CONFIG+=x86_64 ) && /Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile 
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile.Release
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile.qscintilla.Release
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile.qcustomplot.Release
make[2]: Nothing to be done for `first'.
make[2]: Nothing to be done for `first'.
cd src/ && ( test -e Makefile || /Users/jc/Qt/5.11.3/clang_64/bin/qmake -o Makefile /Users/jc/git_repos/sqlitebrowser/src/src.pro -spec macx-clang CONFIG+=x86_64 ) && /Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile 
cd libs/json/ && ( test -e Makefile || /Users/jc/Qt/5.11.3/clang_64/bin/qmake -o Makefile /Users/jc/git_repos/sqlitebrowser/libs/json/json.pro -spec macx-clang CONFIG+=x86_64 ) && /Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile 
make[2]: Nothing to be done for `first'.
xcrun: error: no utility name specified
Usage: xcrun [options] <tool name> ... arguments ...

Find and execute the named command line tool from the active developer
directory.

The active developer directory can be set using `xcode-select`, or via the
DEVELOPER_DIR environment variable. See the xcrun and xcode-select manual
pages for more information.

Options:
  -h, --help                  show this help message and exit
  --version                   show the xcrun version
  -v, --verbose               show verbose logging output
  --sdk <sdk name>            find the tool for the given SDK name
  --toolchain <name>          find the tool for the given toolchain
  -l, --log                   show commands to be executed (with --run)
  -f, --find                  only find and print the tool path
  -r, --run                   find and execute the tool (the default behavior)
  -n, --no-cache              do not use the lookup cache
  -k, --kill-cache            invalidate all existing cache entries
  --show-sdk-path             show selected SDK install path
  --show-sdk-version          show selected SDK version
  --show-sdk-build-version    show selected SDK build version
  --show-sdk-platform-path    show selected SDK platform path
  --show-sdk-platform-version show selected SDK platform version
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile.Release
rm -f libjson.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar cq libjson.a 
ar: no archive members specified
usage:  ar -d [-TLsv] archive file ...
	ar -m [-TLsv] archive file ...
	ar -m [-abiTLsv] position archive file ...
	ar -p [-TLsv] archive [file ...]
	ar -q [-cTLsv] archive file ...
	ar -r [-cuTLsv] archive file ...
	ar -r [-abciuTLsv] position archive file ...
	ar -t [-TLsv] archive [file ...]
	ar -x [-ouTLsv] archive [file ...]
make[2]: *** [libjson.a] Error 1
make[1]: *** [release] Error 2
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f Makefile.Release
make: *** [sub-libs-json-json-pro-make_first] Error 2
make: *** Waiting for unfinished jobs....
/Users/jc/Qt/5.11.3/clang_64/bin/uic MainWindow.ui -o .ui/ui_MainWindow.h
/Users/jc/Qt/5.11.3/clang_64/bin/uic EditIndexDialog.ui -o .ui/ui_EditIndexDialog.h

[scottfurry]

FWIW...
Linux
GCC 9.2.1
CMAKE 3.15.0
Qt 5.12.5

Build completes but there are some similar and noisy warnings WRT enum values:

src/Data.cpp:52:15: warning: enumeration value ‘DirL’ not handled in switch [-Wswitch]
   52 |         switch(ch.direction()) {
      |               ^

non-void return:

src/CondFormat.cpp:15:1: warning: control reaches end of non-void function [-Wreturn-type]
   15 | }
      | ^

...and then a pile of warnings about sqlite3_lexer.cpp

sqlite3_lexer.cpp: In function ‘void* yyalloc(yy_size_t, yyscan_t)’
sqlite3_lexer.cpp:3507:44: warning: use of old-style cast to ‘struct yyguts_t*’ [-Wold-style-cast]
...
sqlite3_lexer.cpp: In function ‘void yyrestart(FILE*, yyscan_t)’:
sqlite3_lexer.cpp:2889:20: warning: potential null pointer dereference [-Wnull-dereference]
sqlite3_lexer.cpp:2885:19: warning: potential null pointer dereference [-Wnull-dereference]

Some things may need a bit of clean up.

[MKleusberg]

Especially for the lexer I would suggest disabling warnings altogether. It's auto generated code anyway.

@justinclift Can you try again with the latest commit included? I hope that missing include might fix the build or at least a large part of the error messages 😄

[justinclift]

@MKleusberg Thanks, adding that include worked. 😄

[MKleusberg]

Awesome 😄

[mgrojo]

When the Windows nightly fails, it would be good if the compilation script would upload the compilation log to the nightly servers, so we could check quickly what happened and fix the problem.

[revolter]

I still get [libjson.a] Error 1 using Qt Creator.

[MKleusberg]

@revolter Can you paste the last couple of lines before this message in here? Also, can you try to rebuild with this patch applied? After cleaning up any leftover makefiles and object files, of course.

diff --git a/libs/json/json.pro b/libs/json/json.pro
index e0fe2ea6..4ae53374 100644
--- a/libs/json/json.pro
+++ b/libs/json/json.pro
@@ -1,6 +1,5 @@
-TEMPLATE = lib
+TEMPLATE = subdirs
 
-CONFIG += staticlib
 CONFIG += debug_and_release
 
 HEADERS += \