fix(ci) :: improve CI to be less flakey - #1416
Merged
Merged
Conversation
81reap
commented
Aug 31, 2026
81reap
commented
Contributor
- fix(ci) :: wait for mysql and mariadb to accept connections before running the tests
- fix(ci) :: replace sleep 15 with poll for mysql
- fix(ci) :: make setup idempotent
…nning the tests `docker compose up --wait` without a healthcheck reports a container as healthy as soon as it starts. Now mysql and mariadb have heathchecks just like the other dbs.
81reap
marked this pull request as ready for review
August 31, 2026 21:16
This was referenced Aug 31, 2026
lovasoa
approved these changes
Sep 1, 2026
Collaborator
|
thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.