Skip to content

Fix nested array default constructor lookup #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitagarwal1301 wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −3
Open

Fix nested array default constructor lookup #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions moshi-kotlin-codegen/src/main/java/com/squareup/moshi/kotlin/codegen/api/kotlintypes.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,12 @@ internal fun TypeName.asTypeBlock(): CodeBlock {
return if (rawType == ARRAY) {
val componentType = typeArguments[0]
if (componentType is ParameterizedTypeName) {
// "generic" array just uses the component's raw type
// java.lang.reflect.Array.newInstance(<raw-type>, 0).javaClass
// Render parameterized array components recursively.
// java.lang.reflect.Array.newInstance(<component-type>, 0).javaClass
CodeBlock.of(
"%T.newInstance(%L, 0).javaClass",
Array::class.java.asClassName(),
componentType.rawType.asTypeBlock(),
componentType.asTypeBlock(),
)
} else {
CodeBlock.of("%T::class.java", copy(nullable = false))
Expand Down
9 changes: 9 additions & 0 deletions .../codegen-only/src/test/kotlin/com/squareup/moshi/kotlin/codegen/DefaultConstructorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,17 @@ class DefaultConstructorTest {
val instance = Moshi.Builder().build().adapter<TestClass>().fromJson(json)
check(instance == expected) { "No match:\nActual : $instance\nExpected: $expected" }
}

@Test
fun nestedArrayWithDefault() {
val instance = Moshi.Builder().build().adapter<NestedArrayTestClass>().fromJson("{}")
check(instance.nestedArray.isEmpty())
}
}

@JsonClass(generateAdapter = true)
data class NestedArrayTestClass(val nestedArray: Array<Array<String>> = emptyArray())

@JsonClass(generateAdapter = true)
data class TestClass(
val required: String,
Expand Down