Polish countries and continents - #40
Merged
Merged
Conversation
Collaborator
|
Yeah, I'll have to add the repos to GitHub and Packagist manually but he rest is automated by GitHub actions :) I will add a PHP-CS-Fixer action too, I have it on other repos. Thanks for the new translation! It will be available in the next release. |
Collaborator
|
Released v3.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, it's me again.
I translated continents and countries datasources into Polish. I'm not 100% sure how the splitting of monorepo works, but I'm assuming that you'll need to at least create
squirephp/continents-plandsquirephp/countries-plpackages in Packagist... or are they being created automagically?I also translated capital cities names according to Urzędowy wykaz polskich nazw geograficznych świata. I saw that you didn't translate cities in German files for example (Warsaw, not Warschau), but I would really could use these Polish names.
Anyway, today I learned that Mauritanian capital Nouakchott in Polish is Nawakszut.
Btw. sorry for double quotes in #38. Have you ever consider adding some ecs tool to GHA?